Dear Daniel Mack,
In message 20090505101606.GD22117@buzzloop.caiaq.de you wrote:
Correct. It does not build anymore. Another possibility is to revert the commit which caused the trouble and make Markus Klotzbuecher fix it in a way Jean-Christophe PLAGNIOL-VILLARD likes.
We will not do that.
- how many PXA platforms with USB support do we have?
That's not the point. I for myself won't bring my board support into U-Boot's mainline (at least not now) because that would help nobody as nobody except for me has the hardware the code was written for. And I guess I'm not the only one.
Well, that is your decision. But if you chose your place intentionally outside the community that you should not be surprised if you only receive pretty limited support from that community either.
IMO hings should compile, even when the config for this is not in your repository; hope you agree.
No, I disagree. I don't care at all about any out-of-tree ports that might exist anywhere. I will not waste any thoughts about the eventual possibility that changes to the mainline U-Boot code might cause problems in such out-of-tree ports. That's not our problem.
In other words - is your concern a real problem, or just a theoretical one?
Code using that macro is guarded by MONAHANS #ifdefs anyway, his point is solely not to have it in the register headers.
...where it could be protected by a similar #ifdef, so I really don't see where the problem is.
Best regards,
Wolfgang Denk