Re: [U-Boot] [RFC PATCH 2/2] ARMV7: OMAP4: Add twl6032 support

On Wed, Jul 24, 2013 at 04:56:36PM +0300, Oleg Kosheliev wrote:

From: Oleg Kosheliev oleg.kosheliev@ti.com

Added chip type detection and twl6032 support in the battery control and charge functions.

Based on Balaji T K balajitk@ti.com patches for TI u-boot.

Signed-off-by: Oleg Kosheliev oleg.kosheliev@ti.com

[snip]

• ret = twl6030_i2c_read_u8(TWL6030_CHIP_USB, USB_PRODUCT_ID_LSB, &val);
• if (ret) {

• printf("twl6030_init_battery_charging(): " \
  

•        "could not determine chip!\n");
  

• return;
  

Please use puts() and don't split text strings, they can be longer than 80char wide.

[snip]

• printf("twl6030_init_battery_charging(): " \
  

•        "unsupported chip type\n");
  

Same.