Hi Calvin,
On Wed, Feb 21, 2018 at 10:32 PM, Calvin Johnson calvin.johnson@nxp.com wrote:
Hi Joe,
-----Original Message----- From: Calvin Johnson [mailto:calvin.johnson@nxp.com] Sent: Thursday, February 15, 2018 7:47 PM To: u-boot@lists.denx.de Cc: joe.hershberger@ni.com; York Sun york.sun@nxp.com; Anji Jagarlmudi anji.jagarlmudi@nxp.com; Calvin Johnson calvin.johnson@nxp.com Subject: [PATCH v2 00/13] LS1012A PFE driver patch series
<snip>
Changes in v2 series:
- PFE patches submitted on top of this base patch are now merged to
this patch. 2. Platform changes are segregated into different patches. 3. Network enabled on 2g5rdb platform 4. Moved from legacy to new driver model.
Gentle reminder. Hope the PFE patches didn't miss your sight.
I tried applying your series and it had many checkpatch issues. Please resolve those and resend.
Thanks, -Joe
-----------------
Fetched U-Boot-1-9-drivers-net-pfe_eth-LS1012A-PFE-driver-introduction (823206.mbox) 823206.mbox:46: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? 823206.mbox:534: CHECK: Avoid CamelCase: <Elf32_Shdr> 823206.mbox:551: CHECK: No space is necessary after a cast 823206.mbox:669: CHECK: spaces preferred around that '&' (ctx:ExV) 823206.mbox:728: CHECK: Unbalanced braces around else statement 823206.mbox:835: WARNING: else is not generally useful after a break or return 823206.mbox:1231: CHECK: Please use a blank line after function/struct/union/enum declarations 823206.mbox:1237: CHECK: spaces preferred around that '<<' (ctx:VxV) 823206.mbox:1237: CHECK: spaces preferred around that '|' (ctx:VxV) 823206.mbox:1461: CHECK: Comparison to NULL could be written "!g_rx_desc" 823206.mbox:1487: CHECK: Comparison to NULL could be written "!g_rx_desc" 823206.mbox:1520: CHECK: Comparison to NULL could be written "!rx_desc" 823206.mbox:1573: CHECK: Comparison to NULL could be written "!g_tx_desc" 823206.mbox:1606: CHECK: Comparison to NULL could be written "!tx_desc" 823206.mbox:1891: WARNING: Statements should start on a tabstop 823206.mbox:1901: WARNING: Statements should start on a tabstop 823206.mbox:1937: CHECK: spaces preferred around that '|' (ctx:VxV) 823206.mbox:2100: CHECK: Please don't use multiple blank lines 823206.mbox:2118: CHECK: Please don't use multiple blank lines 823206.mbox:2132: WARNING: suspect code indent for conditional statements (8, 24) 823206.mbox:2178: CHECK: Alignment should match open parenthesis 823206.mbox:2462: CHECK: Avoid CamelCase: <Elf32_Ehdr> 823206.mbox:2605: CHECK: Prefer kernel type 'u8' over 'uint8_t' total: 0 errors, 5 warnings, 18 checks, 2580 lines checked Checking patch drivers/net/pfe_eth/Kconfig... Checking patch drivers/net/pfe_eth/Makefile... Checking patch drivers/net/pfe_eth/pfe.c... Checking patch drivers/net/pfe_eth/pfe_driver.c... Checking patch drivers/net/pfe_eth/pfe_eth.c... Checking patch drivers/net/pfe_eth/pfe_firmware.c... Applied patch drivers/net/pfe_eth/Kconfig cleanly. Applied patch drivers/net/pfe_eth/Makefile cleanly. Applied patch drivers/net/pfe_eth/pfe.c cleanly. Applied patch drivers/net/pfe_eth/pfe_driver.c cleanly. Applied patch drivers/net/pfe_eth/pfe_eth.c cleanly. Applied patch drivers/net/pfe_eth/pfe_firmware.c cleanly. Applying: drivers: net: pfe_eth: LS1012A PFE driver introduction Fetched U-Boot-2-9-drivers-net-pfe_eth-provide-pfe-commands (823207.mbox) 823207.mbox:43: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? 823207.mbox:83: WARNING: line over 80 characters 823207.mbox:94: CHECK: spaces preferred around that '&' (ctx:VxV) 823207.mbox:117: WARNING: line over 80 characters 823207.mbox:128: CHECK: spaces preferred around that '&' (ctx:VxV) 823207.mbox:141: WARNING: line over 80 characters 823207.mbox:152: WARNING: line over 80 characters 823207.mbox:166: WARNING: line over 80 characters 823207.mbox:184: WARNING: line over 80 characters 823207.mbox:193: WARNING: line over 80 characters 823207.mbox:248: WARNING: line over 80 characters 823207.mbox:294: WARNING: Prefer using '"%s...", __func__' to using 'gpi', this function's name, in a string 823207.mbox:307: WARNING: Prefer using '"%s...", __func__' to using 'bmu', this function's name, in a string 823207.mbox:385: WARNING: suspect code indent for conditional statements (16, 16) 823207.mbox:385: CHECK: Unbalanced braces around else statement 823207.mbox:393: WARNING: line over 80 characters 823207.mbox:405: WARNING: Missing a blank line after declarations 823207.mbox:444: WARNING: line over 80 characters 823207.mbox:448: WARNING: void function return statements are not generally useful 823207.mbox:532: CHECK: spaces preferred around that '+' (ctx:VxV) 823207.mbox:546: CHECK: spaces preferred around that '+' (ctx:VxV) 823207.mbox:578: CHECK: Please don't use multiple blank lines total: 0 errors, 16 warnings, 6 checks, 544 lines checked Checking patch drivers/net/pfe_eth/Makefile... Checking patch drivers/net/pfe_eth/pfe_cmd.c... Applied patch drivers/net/pfe_eth/Makefile cleanly. Applied patch drivers/net/pfe_eth/pfe_cmd.c cleanly. Applying: drivers: net: pfe_eth: provide pfe commands Fetched U-Boot-3-9-drivers-net-pfe_eth-LS1012A-PFE-headers (823209.mbox) 823209.mbox:50: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? 823209.mbox:101: CHECK: spaces preferred around that '<<' (ctx:VxV) 823209.mbox:101: CHECK: Prefer using the BIT macro 823209.mbox:103: CHECK: spaces preferred around that '<<' (ctx:VxV) 823209.mbox:105: CHECK: spaces preferred around that '<<' (ctx:VxV) 823209.mbox:105: CHECK: Prefer using the BIT macro 823209.mbox:106: CHECK: spaces preferred around that '<<' (ctx:VxV) 823209.mbox:106: CHECK: Prefer using the BIT macro 823209.mbox:108: CHECK: Macro argument reuse 'size' - possible side-effects? 823209.mbox:119: CHECK: Prefer using the BIT macro 823209.mbox:124: CHECK: Prefer using the BIT macro 823209.mbox:340: CHECK: Prefer using the BIT macro 823209.mbox:341: CHECK: Prefer using the BIT macro 823209.mbox:342: CHECK: Prefer using the BIT macro 823209.mbox:343: CHECK: Prefer using the BIT macro 823209.mbox:344: CHECK: Prefer using the BIT macro 823209.mbox:345: CHECK: Prefer using the BIT macro 823209.mbox:346: CHECK: Prefer using the BIT macro 823209.mbox:348: CHECK: Prefer using the BIT macro 823209.mbox:351: CHECK: Prefer using the BIT macro 823209.mbox:353: CHECK: Prefer using the BIT macro 823209.mbox:354: CHECK: Prefer using the BIT macro 823209.mbox:355: CHECK: Prefer using the BIT macro 823209.mbox:628: CHECK: spaces preferred around that '<<' (ctx:VxV) 823209.mbox:628: CHECK: Prefer using the BIT macro 823209.mbox:629: CHECK: spaces preferred around that '<<' (ctx:VxV) 823209.mbox:629: CHECK: Prefer using the BIT macro 823209.mbox:630: CHECK: spaces preferred around that '<<' (ctx:VxV) 823209.mbox:630: CHECK: Prefer using the BIT macro 823209.mbox:633: CHECK: spaces preferred around that '<<' (ctx:VxV) 823209.mbox:633: CHECK: Prefer using the BIT macro 823209.mbox:636: CHECK: Prefer using the BIT macro 823209.mbox:637: CHECK: Prefer using the BIT macro 823209.mbox:638: CHECK: Prefer using the BIT macro 823209.mbox:639: CHECK: Prefer using the BIT macro 823209.mbox:640: CHECK: Prefer using the BIT macro 823209.mbox:649: CHECK: Prefer using the BIT macro 823209.mbox:650: CHECK: Prefer using the BIT macro 823209.mbox:651: CHECK: Prefer using the BIT macro 823209.mbox:652: CHECK: Prefer using the BIT macro 823209.mbox:653: CHECK: Prefer using the BIT macro 823209.mbox:654: CHECK: Prefer using the BIT macro 823209.mbox:655: CHECK: Prefer using the BIT macro 823209.mbox:656: CHECK: Prefer using the BIT macro 823209.mbox:657: CHECK: Prefer using the BIT macro 823209.mbox:658: CHECK: Prefer using the BIT macro 823209.mbox:839: CHECK: Prefer using the BIT macro 823209.mbox:840: CHECK: Prefer using the BIT macro 823209.mbox:841: CHECK: Prefer using the BIT macro 823209.mbox:842: CHECK: Prefer using the BIT macro 823209.mbox:843: CHECK: Prefer using the BIT macro 823209.mbox:844: CHECK: Prefer using the BIT macro 823209.mbox:845: CHECK: Prefer using the BIT macro 823209.mbox:846: CHECK: Prefer using the BIT macro 823209.mbox:847: CHECK: Prefer using the BIT macro 823209.mbox:848: CHECK: spaces preferred around that '<<' (ctx:VxV) 823209.mbox:848: CHECK: Prefer using the BIT macro 823209.mbox:964: CHECK: Macro argument reuse 'addr' - possible side-effects? 823209.mbox:967: CHECK: Macro argument reuse 'addr' - possible side-effects? 823209.mbox:970: CHECK: Macro argument reuse 'addr' - possible side-effects? 823209.mbox:974: CHECK: Macro argument reuse 'addr' - possible side-effects? 823209.mbox:978: CHECK: Macro argument reuse 'addr' - possible side-effects? 823209.mbox:1030: CHECK: Prefer using the BIT macro 823209.mbox:1071: CHECK: Avoid CamelCase: <Elf32_Shdr> 823209.mbox:1125: WARNING: Adding new packed members is to be done with care 823209.mbox:1133: WARNING: Adding new packed members is to be done with care total: 0 errors, 3 warnings, 63 checks, 1172 lines checked Checking patch include/pfe_eth/pfe/cbus.h... Checking patch include/pfe_eth/pfe/cbus/bmu.h... Checking patch include/pfe_eth/pfe/cbus/class_csr.h... Checking patch include/pfe_eth/pfe/cbus/emac.h... Checking patch include/pfe_eth/pfe/cbus/gpi.h... Checking patch include/pfe_eth/pfe/cbus/hif.h... Checking patch include/pfe_eth/pfe/cbus/hif_nocpy.h... Checking patch include/pfe_eth/pfe/cbus/tmu_csr.h... Checking patch include/pfe_eth/pfe/cbus/util_csr.h... Checking patch include/pfe_eth/pfe/pfe.h... Checking patch include/pfe_eth/pfe_driver.h... Checking patch include/pfe_eth/pfe_eth.h... Checking patch include/pfe_eth/pfe_firmware.h... Applied patch include/pfe_eth/pfe/cbus.h cleanly. Applied patch include/pfe_eth/pfe/cbus/bmu.h cleanly. Applied patch include/pfe_eth/pfe/cbus/class_csr.h cleanly. Applied patch include/pfe_eth/pfe/cbus/emac.h cleanly. Applied patch include/pfe_eth/pfe/cbus/gpi.h cleanly. Applied patch include/pfe_eth/pfe/cbus/hif.h cleanly. Applied patch include/pfe_eth/pfe/cbus/hif_nocpy.h cleanly. Applied patch include/pfe_eth/pfe/cbus/tmu_csr.h cleanly. Applied patch include/pfe_eth/pfe/cbus/util_csr.h cleanly. Applied patch include/pfe_eth/pfe/pfe.h cleanly. Applied patch include/pfe_eth/pfe_driver.h cleanly. Applied patch include/pfe_eth/pfe_eth.h cleanly. Applied patch include/pfe_eth/pfe_firmware.h cleanly. Applying: drivers: net: pfe_eth: LS1012A PFE headers Fetched U-Boot-4-9-board-freescale-ls1012a-enable-network-support-on-ls1012a-platforms (823210.mbox) 823210.mbox:55: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? 823210.mbox:122: WARNING: Block comments use a trailing */ on a separate line 823210.mbox:142: CHECK: Please don't use multiple blank lines 823210.mbox:239: CHECK: Alignment should match open parenthesis 823210.mbox:249: CHECK: Alignment should match open parenthesis 823210.mbox:344: WARNING: Block comments use a trailing */ on a separate line 823210.mbox:364: WARNING: suspect code indent for conditional statements (16, 32) 823210.mbox:389: WARNING: Block comments use a trailing */ on a separate line 823210.mbox:400: WARNING: suspect code indent for conditional statements (16, 32) 823210.mbox:511: WARNING: suspect code indent for conditional statements (32, 32) 823210.mbox:538: WARNING: suspect code indent for conditional statements (32, 32) 823210.mbox:674: CHECK: Please don't use multiple blank lines total: 0 errors, 8 warnings, 4 checks, 640 lines checked [ ... ]