Le 12/04/2018 à 14:58, Gary Bisson a écrit :
Hi Guillaume,
On Thu, Apr 12, 2018 at 02:48:07PM +0200, Guillaume Gardet wrote:
Le 12/04/2018 à 14:36, Gary Bisson a écrit :
Hi Fabio, Guillaume
On Thu, Apr 12, 2018 at 08:14:51AM -0300, Fabio Estevam wrote:
On Thu, Apr 12, 2018 at 5:13 AM, Guillaume Gardet guillaume.gardet@free.fr wrote: script that picks the correct dtb.
Ok. So, how would you like to proceed? Remove the generic mx6 'soc' definition and use a board sepcific 'board_rev' (or maybe a static definition if one configuration match a single dtb) to define the right dtb?
I prefer to keep the same solution as done in other boards sucn as mx6sabresd, wandboard and cuboxi.
Ok. My suggestion was to have something generic so that it matches the fdt name set in config_distro_bootcmd.h (${soc}-${board}${boardver}.dtb).
I especially like the naming in that standard, don't think board_rev should be the SOC name.
This would also avoid redundancy in each board_late_init functions since only the board name would need to be setup (and boardver in some cases like wandboard).
Guillaume, please forget that point for now and just set your fdtfile name in the config file. I'll update the board file later on.
Ok.
Could you just confirm which DTB should work with the various nitrogen6x boards config, please? Are the following ok?
- imx6q-nitrogen6x.dts => nitrogen6q2g_defconfig nitrogen6q_defconfig
- imx6dl-nitrogen6x.dts => nitrogen6dl2g_defconfig nitrogen6dl_defconfig
- imx6sx-nitrogen6sx.dts => nitrogen6s1g_defconfig nitrogen6s_defconfig
No, imx6sx is different than imx6s. Solo is the same as imx6dl as far as the kernl is concerned.
Maybe just leave fdt_file blank for nitrogen6x for now, it's only necessary for PXE which isn't enabled in nitrogen6*defconfig.
Ok, I will leave it as is for now, but fdtfile must also be defined for EFI boot. Otherwise, you start your EFI payload without device tree.
Guillaume
Regards, Gary