Dear Graeme Russ,
In message 48CE15B3.1030305@gmail.com you wrote:
Several minor corrections to allow clean builds of new i386 and sc520 based boards based on 2008.10
Soory, but some parts of this cannot work:
--- a/examples/82559_eeprom.c +++ b/examples/82559_eeprom.c @@ -19,7 +19,6 @@ */
#define _PPC_STRING_H_ /* avoid unnecessary str/mem functions */ -#define _LINUX_STRING_H_ /* avoid unnecessary str/mem functions */
Will this still build for other architectures, say ARM and MIPS and Power?
diff --git a/lib_i386/video_bios.c b/lib_i386/video_bios.c index ce96a3e..1541773 100644 --- a/lib_i386/video_bios.c +++ b/lib_i386/video_bios.c @@ -21,6 +21,8 @@
- MA 02111-1307 USA
*/
+#ifdef CONFIG_VIDEO
#include <common.h> #include <pci.h> #include <malloc.h>
This cannot work. CONFIG_VIDEO can only be set in the board config file, which gets included implicitly by #include <common.h>, but you use the variable before that, so it will always be undefined, which is probably not what you intend.
Best regards,
Wolfgang Denk