On Mon, 2014-10-06 at 10:37 +0200, Hans de Goede wrote:
Hi,
On 10/04/2014 10:37 AM, Ian Campbell wrote:
On Fri, 2014-10-03 at 17:05 +0200, Hans de Goede wrote:
None of the known sunxi devices actually use mmc1 routed through PH, where as some devices do actually use mmc1 routed through PG, so change the routing of mmc1 to PG. If in the future we encounter devices with mmc1 routed through PH, we will need to change things to be a bit more flexible.
Signed-off-by: Hans de Goede hdegoede@redhat.com
Acked-by: Ian Campbell ian.campbell@citrix.com
Although it seems that adding a Kconfig choice option would only be a dozen or so lines of pretty trivial stuff if we wanted to do it now.
This mostly seems to be a sun4i/sun7i vs sun5i thing. mmc1 could be routed through PH on sun4i/sun7i, but actually is never used there, as PH typically is used for gpio purposed on sun4i/sun7i, where as on sun5i (which has way less pins), mmc1 goes out on PG, and actually is used as such there.
I have considered keeping the old pinmux settings using #if defined SUN5I for the new ones, but since the old ones are never used just replacing them seems better.
Sure.
Ian.