On 18.04.2019, at 04:57, Kever Yang kever.yang@rock-chips.com wrote:
Hi Jagan,
On 04/17/2019 07:11 PM, Jagan Teki wrote:
On Wed, Apr 17, 2019 at 1:10 PM Kever Yang kever.yang@rock-chips.com wrote:
Hi Jagan,
On 04/16/2019 06:56 PM, Jagan Teki wrote:
Add sdram dtsi file for 4GB LPDDR3-1866 DMC settings by reverse engineered from the rk3399_ddr_933Mhz_v1.14.bin file.
Full credits to 'Liviu Dudau' who is the real author for this change.
Signed-off-by: Liviu Dudau liviu@dudau.co.uk Signed-off-by: Jagan Teki jagan@amarulasolutions.com
.../arm/dts/rk3399-sdram-lpddr3-4GB-1866.dtsi | 1535 +++++++++++++++++
Could you use rk3399-sdram-lpddr3-samsung-4GB-1866.dtsi directly? I think it should able to work.
I supposed to take the same, but thought that it would be some samsung specific setting. but seems like it is nearly same and it worked. will update to use this. thanks!
I have check with rockchip dram driver owner, this setting is more generic while the -samsung- dtsi is more for dedicate chromebook. So I think we can merge this patch for other boards who using Rockchip reference design.
Reviewed-by: Kever Yang kever.yang@rock-chips.com
Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com