On Wed, Jul 09, 2014 at 05:18:09PM +0200, Stefan Roese wrote:
Commit a0a37183 (ARM: omap: merge GPMC initialization code for all platform) broke NAND on OMAP3 based platforms. I noticed this while testing the latest 2014.07-rc version on the TAO3530 board. NAND detection did not work with this error message:
NAND: nand: error: Unable to find NAND settings in GPMC Configuration - quitting
As OMAP3 configs don't set CONFIG_NAND but CONFIG_NAND_CMD. the GPMC was not initialized for NAND at all. This patch now fixes this issue.
Tested on TAO3530 board.
Signed-off-by: Stefan Roese sr@denx.de Cc: Pekon Gupta pekon@ti.com Cc: Tom Rini trini@ti.com Acked-by: Pekon Gupta pekon@ti.com
Please note that this introduces build failure on the tricorder platforms but is a bugfix. Thomas, tricorder is currently broken in that NAND doesn't work without this patch. With this patch we're now too big in SPL to fit in SRAM. I suspect, but this needs run-time testing that we can bump max size / say 6KB for stack, or better yet confirm that like am335x / am43xx / omap4+ we init DDR prior to putting CONFIG_SPL_STACK into sp and can use the whole of SRAM for SPL and have stack be an address in DDR (see http://patchwork.ozlabs.org/patch/371636/).
Applied to u-boot-ti/master, thanks!