Hi Lukasz,
Am 18.03.2019 um 08:23 schrieb Lukasz Majewski:
On Fri, 15 Mar 2019 20:02:25 +0100 Simon Goldschmidt simon.k.r.goldschmidt@gmail.com wrote:
Tom,
(adding Lukasz as he authored the DM fix 0c07a9b4078d)
Am 14.03.2019 um 21:57 schrieb Simon Goldschmidt:
This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51.
The 'eeprom' command has been converted to work with DM_I2C in a patch submitted around the same time as this commit: commit 0c07a9b4078d ("eeprom: Add device model based I2C support to eeprom command")
Signed-off-by: Simon Goldschmidt simon.k.r.goldschmidt@gmail.com
I know it's late in the release cycle, but is there a chance to get this in for v2019.04?
That would allow me to convert I2C and EEPROM access for socfpga in the socfpga-next tree...
Also, I guess adding this now shouldn't be a great risk since it is default off and removing the dependency shouldn't harm.
If it doesn't cause build breaks - I don't mind.
I don't see why this should cause build breaks. It's default off and not selected anywhere: although 101 defconfig files have CONFIG_CMD_EEPROM enabled, none of them has CONFIG_DM_I2C enabled.
Your patch from Nov/Dec 2018 should allow those boards to move to DM_I2C (if the i2c driver supports it) but the commit I want to revert here prevents it soemwhat by depending on legacy code: even DM_I2C_COMPAT is not needed any more after your patch.
Regards, Simon
Thanks, Simon
cmd/Kconfig | 1 - 1 file changed, 1 deletion(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig index 4bcc5c4557..74c5a1a6ed 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -455,7 +455,6 @@ config CRC32_VERIFY
config CMD_EEPROM bool "eeprom - EEPROM subsystem"
- depends on !DM_I2C || DM_I2C_COMPAT help (deprecated, needs conversion to driver model) Provides commands to read and write EEPROM
(Electrically Erasable
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de