
24 Jan
2011
24 Jan
'11
1:37 p.m.
Dear Haiying Wang,
In message 1295840749.2196.3.camel@haiying-laptop you wrote:
+#ifdef CONFIG_FSL_CORENET
- return (gd->bus_clk + 8) / 16;
+#else
- return (gd->bus_clk + 4UL)/8UL;
+#endif
This looks inconsistent. Either this should be "... +8UL) / 16UL" or "... + 4) / 8;"
This part was copied from arch/powerpc/cpu/mpc85xx/cpu.c, just want too reduce the image size without including that file(cpu.c). Will fix it.
Instead of copying, can we please move it to some common code?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
It is wrong always, everywhere and for everyone to believe anything
upon insufficient evidence. - W. K. Clifford, British philosopher,
circa 1876