Joe
On 04/26/2016 04:42 PM, Joe Hershberger wrote:
On Mon, Apr 25, 2016 at 4:32 PM, Joe Hershberger joe.hershberger@gmail.com wrote:
On Fri, Apr 15, 2016 at 7:27 AM, Dan Murphy dmurphy@ti.com wrote:
Add the ability to read the phy-handle node of the cpsw slave. Upon reading this handle the phy-id can be stored based on the reg node in the DT.
It would be great if the phy could be handled generically. Unfortunately there is no uniform description so far, so having each driver parse it is the best we can do for now.
The phy-handle also needs to be stored and passed to the phy to access any phy data that is available.
Signed-off-by: Dan Murphy dmurphy@ti.com
Acked-by: Joe Hershberger joe.hershberger@ni.com
This patch is not checkpatch.pl clean. Please resubmit.
610946.mbox:57: WARNING: line over 80 characters 610946.mbox:59: WARNING: line over 80 characters 610946.mbox:62: WARNING: line over 80 characters 610946.mbox:62: CHECK: Alignment should match open parenthesis 610946.mbox:65: WARNING: line over 80 characters 610946.mbox:66: WARNING: line over 80 characters total: 0 errors, 5 warnings, 1 checks, 39 lines checked
I can only fix a few there will still be at least 2 LTL warnings on this file and fixing it will break readability
I don't see how to fix this.
WARNING: line over 80 characters #46: FILE: drivers/net/cpsw.c:1230: + if (priv->data.slave_data[slave_index].phy_of_handle >= 0) {
WARNING: line over 80 characters #49: FILE: drivers/net/cpsw.c:1233: + priv->data.slave_data[slave_index].phy_of_handle,
Dan