Hi Masahiro,
On 27 July 2014 10:46, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Hi Simon,
On Sat, 26 Jul 2014 17:10:05 +0100 Simon Glass sjg@chromium.org wrote:
Hi Masahiro,
On 22 July 2014 16:24, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
This series introduces Kconfig. For boards with SPL/TPL support, another .config file is created under spl/tpl directory.
Use "make spl:config", "make spl:menuconfig" etc. to modify spl/.config and "make tpl:config", "make tpl:menuconfig" etc. for tpl/.config.
This doesn't seem to work for me now:
Uh-oh, I was such an idiot that I did not notice this syntax does not work. :-(
Ah yes sorry I should have remembered that. It's been a while since I played with it.
I changed that in v6.
Please do
"make spl/config", "make spl/menuconfig", etc.
$ rm -rf b/snow; CROSS_COMPILE=/opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.8-2013.08_linux/bin/arm-linux-gnueabihf- make O=b/snow snow_defconfig spl:xconfig Makefile:134: *** multiple target patterns. Stop.
In case I have missed a patch, I pushed it to u-boot-x86.git in branch try-masa4.
I don't think you missed any patch, but I pushed my local branch to GitHub just in case.
You can use it, if necessary.
git clone git://github.com/masahir0y/u-boot-kbuild.git cd u-boot-kbuild git checkout kconfig_v6
make O=b/snow snow_defconfig spl/xconfig should work.
Yes everything works fine with the latest series thanks, it looks good. I don't think I need to add any more Acks. Looking forward to getting this in!
Also some thoughts for the future:
1. The 'menuconfig' option makes it obvious that we are dealing with U-Boot / SPL / TPL. Can we do the same for 'xconfig'?
2. If I do 'make tpl/menuconfig' and there is no TPL defined, I wonder if it should give an error rather than allowing you to edit it?
3. With all of this code applied we could use some documentation about the defconfig file format and how it interacts with the board config files. This could come from your commit messages perhaps.
BTW Python doc strings usually use " instead of ' and :
http://legacy.python.org/dev/peps/pep-0008/#documentation-strings
Regards, Simon