Hi Rob,
On Sun, Aug 6, 2017 at 6:41 PM, Rob Clark robdclark@gmail.com wrote:
On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass sjg@chromium.org wrote:
On 4 August 2017 at 07:16, Bin Meng bmeng.cn@gmail.com wrote:
Hi Rob,
On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark robdclark@gmail.com wrote:
stdin might not be set, which would cause iomux_doenv() to fail therefore causing probe_usb_keyboard() to fail. Furthermore if we do have iomux enabled, the sensible thing (in terms of user experience) would be to simply add ourselves to the list of stdin devices.
This fixes an issue with usbkbd on dragonboard410c with distro- bootcmd, where stdin is not set (so stdinname is null).
Signed-off-by: Rob Clark robdclark@gmail.com
v2: address Bin's review comments v3: fix fail with free()ing if usbkbd is already in stdin env variable pointed out by Simon
(the real v3 this time)
As I mentioned, it's the email title, not the commit title with version number. If you prefer format-patch, then use --subject-prefix="PATCH v3"
common/usb_kbd.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
Reviewed-by: Simon Glass sjg@chromium.org
Question below
diff --git a/common/usb_kbd.c b/common/usb_kbd.c index d2d29cc98f..d71eae61ec 100644 --- a/common/usb_kbd.c +++ b/common/usb_kbd.c @@ -517,7 +517,22 @@ static int probe_usb_keyboard(struct usb_device *dev)
stdinname = getenv("stdin");#if CONFIG_IS_ENABLED(CONSOLE_MUX)
Would this work:
if (CONFIG_IS_ENABLED(CONSOLE_MUX) { .. }
The #ifdef adds a code path that is not tested, so if possible we should try to use the compiler.
I think it would, except maybe if someone compiled w/ -O0 (unresolved symbols at link time).. not sure if that is something we care about?
Can you please resend with a commit title without (v3) but email title with v3?
Regards, Bin