Re: [U-Boot] [PATCH V11 11/13] TI: SPL: make SPL available for other SOCs as TI

On Fri, Dec 16, 2011 at 8:37 AM, Stefano Babic sbabic@denx.de wrote:

The SPL is developped first for TI-OMAPx. The patch move OMAP specific function into OMAP directory.

I wonder if we should fold this into the mv'ing patch as well.

[snip]

diff --git a/include/spl.h b/include/spl.h +/* Boot type */ +#define        MMCSD_MODE_UNDEFINED    0

Not your bad spacing of course, but please fix.

+/* NAND SPL functions */ +void spl_nand_load_image(void); +void spl_arch_nand_init(void);

+/* MMC SPL functions */ +void spl_mmc_load_image(void);

These should be covered by #ifdef CONFIG_SPL_(NAND||MMC)_SUPPORT