Hi Alper,
On Sat, 5 Sep 2020 at 08:44, Alper Nebi Yasak alpernebiyasak@gmail.com wrote:
Currently, binman always runs the compile tools like cc, objcopy, strip, etc. using their literal name. Instead, this patch makes it use the target-specific versions by default, derived from the tool-specific environment variables (CC, OBJCOPY, STRIP, etc.) or from the CROSS_COMPILE environment variable.
For example, the u-boot-elf etype directly uses 'strip'. Trying to run the tests with 'CROSS_COMPILE=i686-linux-gnu- binman test' on an arm64 host results in the '097_elf_strip.dts' test to fail as the arm64 version of 'strip' can't understand the format of the x86 ELF file.
This also adjusts some command.Output() calls that caused test errors or failures to use the target versions of the tools they call. After this, patch, an arm64 host can run all tests with no errors or failures using a correct CROSS_COMPILE value.
Signed-off-by: Alper Nebi Yasak alpernebiyasak@gmail.com
tools/binman/elf.py | 6 +++-- tools/binman/elf_test.py | 4 ++- tools/dtoc/fdt_util.py | 9 ++++--- tools/patman/tools.py | 58 ++++++++++++++++++++++++++++++++++++++++ 4 files changed, 70 insertions(+), 7 deletions(-)
This looks good, but it drops the use of DTC to specify the device-tree compiler. Can you add it back?
Regards, Simon