Re: [PATCH v1] net: eth-uclass: Fix eth_halt

On Mon, Mar 28, 2022 at 9:14 AM qianfanguijin@163.com wrote:

From: qianfan Zhao qianfanguijin@163.com

eth_device_priv maybe unaccessable after @stop handler due to eth device is removed in @stop. Setting private data before @stop handler.

This also fix data abort bug when run dhcp or tftp command via usbnet.

Signed-off-by: qianfan Zhao qianfanguijin@163.com

net/eth-uclass.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/net/eth-uclass.c b/net/eth-uclass.c index 58c308f332..c6eb1bc8f8 100644 --- a/net/eth-uclass.c +++ b/net/eth-uclass.c @@ -338,9 +338,14 @@ void eth_halt(void) if (!priv || !priv->running) return;

•   eth_get_ops(current)->stop(current);
  

•   priv->state = ETH_STATE_PASSIVE;
  

Why did you delete this line ?

•   /* Make sure setting private data before @stop handler, it may remove
  

•    * ethernet device and will cause @priv unaccessable.
  

•    * eg:
  

•    * usb_eth_stop -> usb_gadget_release -> device_remove
  

•    */
    priv->running = false;
  

•   eth_get_ops(current)->stop(current);
  

}

int eth_is_active(struct udevice *dev)

2.17.1