It doesn't seem necessary to use memory allocation in this code. The setenv() will make a copy anyway.
Signed-off-by: Simon Glass sjg@chromium.org ---
common/main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/common/main.c b/common/main.c index b0d3ea4..ab1f708 100644 --- a/common/main.c +++ b/common/main.c @@ -10,7 +10,6 @@ #include <common.h> #include <autoboot.h> #include <cli.h> -#include <malloc.h> #include <version.h>
DECLARE_GLOBAL_DATA_PTR; @@ -26,10 +25,9 @@ static void modem_init(void) #ifdef CONFIG_MODEM_SUPPORT debug("DEBUG: main_loop: gd->do_mdm_init=%lu\n", gd->do_mdm_init); if (gd->do_mdm_init) { - char *str = strdup(getenv("mdm_cmd")); + char *str = getenv("mdm_cmd"); + setenv("preboot", str); /* set or delete definition */ - if (str != NULL) - free(str); mdm_init(); /* wait for modem connection */ } #endif /* CONFIG_MODEM_SUPPORT */