Re: [U-Boot] [PATCH 2/4] udoo: Add SATA disk support.

Hi Giuseppe,

On 06/11/2013 21:37, Giuseppe Pagano wrote:

Add Sata support on uDoo Board.

Signed-off-by: Giuseppe Pagano giuseppe.pagano@seco.com Cc: sbabic@denx.de

---

diff -uNr a/board/udoo/udoo.c b/board/udoo/udoo.c --- a/board/udoo/udoo.c 2013-11-06 18:45:22.000000000 +0100 +++ b/board/udoo/udoo.c 2013-11-06 18:46:00.000000000 +0100 @@ -208,6 +208,32 @@ return 0; }

+#ifdef CONFIG_CMD_SATA +int setup_sata(void) +{

• struct iomuxc_base_regs *const iomuxc_regs

• = (struct iomuxc_base_regs *)IOMUXC_BASE_ADDR;
  

• int ret = enable_sata_clock();
• if (ret)

• return ret;
  

• clrsetbits_le32(&iomuxc_regs->gpr[13],

• 	IOMUXC_GPR13_SATA_MASK,
  

• 	IOMUXC_GPR13_SATA_PHY_8_RXEQ_3P0DB
  

• 	|IOMUXC_GPR13_SATA_PHY_7_SATA2M
  

• 	|IOMUXC_GPR13_SATA_SPEED_3G
  

• 	|(3<<IOMUXC_GPR13_SATA_PHY_6_SHIFT)
  

• 	|IOMUXC_GPR13_SATA_SATA_PHY_5_SS_DISABLED
  

• 	|IOMUXC_GPR13_SATA_SATA_PHY_4_ATTEN_9_16
  

• 	|IOMUXC_GPR13_SATA_PHY_3_TXBOOST_0P00_DB
  

• 	|IOMUXC_GPR13_SATA_PHY_2_TX_1P104V
  

• 	|IOMUXC_GPR13_SATA_PHY_1_SLOW);
  

• return 0;

+} +#endif

Do not copy code ! If you want to reuse functions from nitrogen, please factorize the function and put it into imx-common, thanks.

Best regards, Stefano Babic