Re: [U-Boot] [PATCH v2] x86: Change printf to puts to avoid a buffer overflow

On 13/11/11 13:02, Gabe Black wrote:

printf as currently implemented in u-boot has a problem where it can overflow an internal buffer if it prints an expanded string that's too long. Our command lines are long enough to cause this problem. A fix should be coming, but in the mean time this change replaces a problematic printf with a few calls to puts that have the same effect. This may perform slightly better because it should avoid a copy and scanning for format specifiers. The amount of time it actually takes up is very tiny relative to everything else so in practice that's probably irrelevant.

Signed-off-by: Gabe Black gabeblack@chromium.org

Applied to u-boot-x86/master

Thanks,

Graeme