Re: [U-Boot] [PATCH 6/7] powerpc/qe: supports loading QE firmware from nand flash

Dear Haiying Wang,

In message 1281947090.24612.23.camel@localhost.localdomain you wrote:

and because some platforms need to load QE firmware from NAND flash(no NOR flash), it makes qe_init to be called after nand_init.

Signed-off-by: Haiying Wang Haiying.Wang@freescale.com

arch/powerpc/cpu/mpc83xx/cpu_init.c | 8 -------- arch/powerpc/cpu/mpc85xx/cpu_init.c | 8 -------- arch/powerpc/lib/board.c | 31 +++++++++++++++++++++++++++++++ 3 files changed, 31 insertions(+), 16 deletions(-)

Please do not throw such stuff into common code. Use board / architecture specific implementations instead (say, provide some misc_init_r() or so).

Best regards,

Wolfgang Denk