7 Feb
2008
7 Feb
'08
4:55 p.m.
+void qe_read_iopin(u8 port, u8 pin, int *data) +{
- u32 pin_1bit_mask;
- u32 tmp_val;
- volatile immap_t *im = (volatile immap_t *)CFG_IMMR;
- volatile qepio83xx_t *par_io = (volatile qepio83xx_t
Don't use volatile. Use the accessor functions: in_be32 and out_be32.
This was copied from the qe_config_iopin function, which still used the volatile directive. I can fix it there as well, but I see that it's used everywhere. Maybe this needs a thorough change, but I'm not sure it should be in my humble patch.
Did you mean 2008?
...
And here
Hehe - will change.
+void qe_read_iopin(u8 port, u8 pin, int *data); +void qe_write_iopin(u8 port, u8 pin, int data);
Put these in a header file.
Will change as well. I think ioports.h is good enough for this purpose. So far, qe_config_iopin wasn't there as well, so it will also be moved there.
David.