Re: [U-Boot-Users] [PATCH] cmd_mfsl: Don't include asm/asm.h on other architectures.

In message 20070516162427.GA10640@ld0162-tx32.am.freescale.net you wrote:

This file currently breaks the build for any architecture other than microblaze due to the absence of asm/asm.h.

Signed-off-by: Scott Wood scottwood@freescale.com

common/cmd_mfsl.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/cmd_mfsl.c b/common/cmd_mfsl.c index 26786aa..ab74dba 100644 --- a/common/cmd_mfsl.c +++ b/common/cmd_mfsl.c @@ -26,13 +26,13 @@

• Microblaze FSL support

*/

+#if (CONFIG_COMMANDS & CFG_CMD_MFSL)

#include <common.h> #include <config.h> #include <command.h> #include <asm/asm.h>

-#if (CONFIG_COMMANDS & CFG_CMD_MFSL)

NACK. You cannot use these defines before including common.h

A fix for this bug was already checked in.

Best regards,

Wolfgang Denk