Hi Rob,
From: Rob Herring robh@kernel.org
Add missing missing disconnect and unbind calls to the musb gadget
^^^^^^^ I suppose that one missing is redundant.
driver's usb_gadget_unregister_driver function. Otherwise, any gadget drivers fail to uninitialize and run a 2nd time.
Signed-off-by: Rob Herring robh@kernel.org
drivers/usb/musb-new/musb_uboot.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb-new/musb_uboot.c b/drivers/usb/musb-new/musb_uboot.c index 0512680..0d7b89f 100644 --- a/drivers/usb/musb-new/musb_uboot.c +++ b/drivers/usb/musb-new/musb_uboot.c @@ -204,7 +204,10 @@ int usb_gadget_register_driver(struct usb_gadget_driver *driver) int usb_gadget_unregister_driver(struct usb_gadget_driver *driver) {
- /* TODO: implement me */
- if (driver->disconnect)
driver->disconnect(&gadget->g);- if (driver->unbind)
driver->unbind(&gadget->g);} #endif /* CONFIG_MUSB_GADGET */
Despite the minor problem with commit message, the rest seems correct.
Reviewed-by: Lukasz Majewski l.majewski@samsung.com