Re: [U-Boot] [PATCH v2 2/6] pci: xilinx: Use pci_generic_mmap_{read, write}_config()

On Wed, Sep 20, 2017 at 4:18 AM, Tuomas Tynkkynen tuomas.tynkkynen@iki.fi wrote:

Use the new helper function to avoid boilerplate in the driver.

Note that this changes __raw_writel et al. to writel. AFAICT this is no problem because:

• The Linux driver for the same hardware uses the non-__raw variants as well (via pci_generic_config_write()).
• This driver seems to be used only on MIPS so far, where the __raw and non-__raw accessors are the same.

Signed-off-by: Tuomas Tynkkynen tuomas.tynkkynen@iki.fi

drivers/pci/pcie_xilinx.c | 53 +++++++---------------------------------------- 1 file changed, 7 insertions(+), 46 deletions(-)

Reviewed-by: Bin Meng bmeng.cn@gmail.com