Dear Andreas,
On 11/07/2010 04:30 PM, Andreas Bießmann wrote:
I guess the boards are broken before your library changes too.
The boards in question do actually build with library archives. The final binary does not make use of the NFS stuff, therefore the linker does not need to resolve the undefined symbols in it.
So yes you need to split these patches.
Understood, I will post separate patches.
But two points regarding your described approach.
- The respective boards need a fix, if they do (conditionally)
disable CMD_NET and miss CMD_NFS it is their fault and the respective boards config should be fixed
The boards unconditionally disable CMD_NET and miss CMD_NFS. Although this is not a meaningful configuration, it used to build...
- The build for net commands need a fix if they will build NFS stuff
without NET stuff
It is possible for net/Makefile to disable all modules if CMD_NET is disabled. I do not know if this is desirable, because it would allow situations where the C code believes that some features will be included and the build system does something else. It seems better to ensure consistency at the board config level, since autoconf.mk is automatically generated from that.
I dunno if it is required to have some config_checks.h, this may grow up to unexpected complexity.
How are dependencies between u-boot modules handled currently? Are they documented or available in any form that could be used to automatically check that a configuration is meaningful?
Best regards,
Sebastien Carlier