On 08/23/2016 04:21 PM, Peter Chubb wrote:
"Stephen" == Stephen Warren swarren@wwwdotorg.org writes:
Stephen> On 08/22/2016 06:00 PM, Peter Chubb wrote:
The Linux-for-Tegra kernel uses a very long command line.
Stephen> There should be a From: line here indicating that Bryan is Stephen> the author; did you actually "git cherry-pick" this, or apply Stephen> it in some other manner? Perhaps you're notusing "git Stephen> send-email" to send the message? That might explain the Stephen> unexpected extra blank line right at the top of the message.
I can't use git send-mail, because our corporate emailer refuses to send with a From line that isn't me. So I did git format-patch and imported it into my email client.
git send-email always uses your own name/address for the SMTP sender and RFC822 header From:. The From: line I'm talking about here is something in the message body. git send-email automatically generates that if the From: line in the patch file it's sending doesn't match your configured name/email.
Or tl;dr, I think you'll find the git send-email works fine for you.
Stephen> Aside from those issues, this looks fine.
So can I add an acked-by line from you, and resubmit (with, if I can work out how to do it, the original From line?)
Well, I didn't ack the patch explicitly since it had some issues I'd like to be addressed, but I suppose if you do address them then you can add acked-by from swarren@nvidia.com on a future posting.