On Mon, Aug 24, 2015 at 04:12:01PM +0000, Alexey Brodkin wrote:
Hi Tom,
On Mon, 2015-08-24 at 12:09 -0400, Tom Rini wrote:
On Mon, Aug 24, 2015 at 07:00:12PM +0300, Alexey Brodkin wrote:
This fixes building in automated flow that doesn't use defconfigs.
See discussion on that topic here: http://patchwork.ozlabs.org/patch/502558/
See similar patches for other architectures/platforms here: [1] http://git.denx.de/?p=u-boot.git;a=commit;h=ff560a13056a565a4e9ce1761bd04276... [2] http://git.denx.de/?p=u-boot.git;a=commit;h=589907e2c187ec69b351c38ccda36730...
And while at it add missing shell prompt to axs103.
Cc: Tom Rini trini@konsulko.com Cc: Joe Hershberger joe.hershberger@gmail.com Cc: Masahiro Yamada yamada.masahiro@socionext.com Signed-off-by: Alexey Brodkin abrodkin@synopsys.com
arch/arc/Kconfig | 2 +- configs/axs101_defconfig | 3 +-- configs/axs103_defconfig | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig index 925e312..264c83d 100644 --- a/arch/arc/Kconfig +++ b/arch/arc/Kconfig @@ -129,7 +129,7 @@ config ARC_CACHE_LINE_SHIFT
choice prompt "Target select"
- optional
- default TARGET_AXS101
config TARGET_TB100 bool "Support tb100" diff --git a/configs/axs101_defconfig b/configs/axs101_defconfig index 9a6cef3..fdb3149 100644 --- a/configs/axs101_defconfig +++ b/configs/axs101_defconfig @@ -1,13 +1,12 @@ CONFIG_ARC=y CONFIG_SYS_DCACHE_OFF=y CONFIG_ARC_CACHE_LINE_SHIFT=5 -CONFIG_TARGET_AXS101=y CONFIG_SYS_CLK_FREQ=750000000 CONFIG_SYS_TEXT_BASE=0x81000000 +CONFIG_SYS_PROMPT="AXS# " # CONFIG_CMD_IMLS is not set # CONFIG_CMD_FLASH is not set # CONFIG_CMD_SETEXPR is not set CONFIG_NETDEVICES=y CONFIG_ETH_DESIGNWARE=y CONFIG_USE_PRIVATE_LIBGCC=y -CONFIG_SYS_PROMPT="AXS# " diff --git a/configs/axs103_defconfig b/configs/axs103_defconfig index 8315b61..b3dbb8d 100644 --- a/configs/axs103_defconfig +++ b/configs/axs103_defconfig @@ -1,8 +1,8 @@ CONFIG_ARC=y CONFIG_ISA_ARCV2=y -CONFIG_TARGET_AXS101=y CONFIG_SYS_CLK_FREQ=50000000 CONFIG_SYS_TEXT_BASE=0x81000000 +CONFIG_SYS_PROMPT="AXS# " # CONFIG_CMD_IMLS is not set # CONFIG_CMD_FLASH is not set # CONFIG_CMD_SETEXPR is not set
It all makes sense. But.. should it be TARGET_ASX10X ? Or is there (or might be..) future 10x devices that wouldn't be supported by the same code / config option?
Indeed we already have axs101 and axs103 as you see in U-Boot. Moreover there's internal thing that stands in between - axs102. And I'm going to do that naming clean-up when time permits but let's say for today that legacy naming stuff is fine.
So yes I'll try to do that sometime soon.
OK thanks and this is fine to do in the mean time as-is.