Re: [U-Boot-Users] [PATCH] Fix offset calculation for multi-type legacy images.

In message 1210453324547-git-send-email-nick.spence@freescale.com you wrote:

Calculation of tail was incorrect when size % 4 == 0.

New code removes the conditional and does the same thing but with arithmetic

Signed-off-by: Nick Spence nick.spence@freescale.com

The minimum change is to re-insert the original check:

if ((uimage_to_cpu (size[i]) % 4) != 0) tail += (4 - uimage_to_cpu (size[i]) % 4);

or a variation on this.

The proposed patch cleans up the code a little further by removing the condition entirely and achieving the same rounding-up effect a little more cleanly and clearly.

common/image.c | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk