On Wed, Aug 31, 2011 at 1:22 PM, Mike Frysinger vapier@gentoo.org wrote:
On Wednesday, August 31, 2011 16:05:38 Simon Glass wrote:
On Wed, Aug 31, 2011 at 12:18 PM, Wolfgang Denk wrote:
Simon Glass wrote:
nit: circular. Just a suggestion if you like: you could also offer guidance for the location of the buffer, something like:
You can place the buffer at the top of memory by adding something like this in your board config file:
#define CONFIG_PRE_CON_BUF_ADDR (CONFIG_SYS_INIT_RAM_ADDR
- \ CONFIG_SYS_INIT_RAM_SIZE - \ CONFIG_PRE_CON_BUF_SZ)
#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_PRE_CON_BUF_ADDR - \ GENERATED_GBL_DATA_SIZE)
That would only make sense if these were generic options that are used across all boards and architectures.
Yes ok - its' already decided not to put this code in arch/xxx/board.c so let's leave this out then.
fwiw, i'll probably do that in Blackfin's default arch config.h so that boards get a sane default that'll work across all Blackfin cpus
SGTM - this sort of address arithmetic in every board header file is a bit ick.
-mike