Dear Stefan Roese,
In message 1247068015-16224-1-git-send-email-sr@denx.de you wrote:
This patch adds support for the Keymile SUEN3 board which is based on the Marvell Kirkwood (88F6281) SoC.
...
diff --git a/MAKEALL b/MAKEALL index 41f1445..6c80694 100755 --- a/MAKEALL +++ b/MAKEALL @@ -524,6 +524,7 @@ LIST_ARM9=" \ scb9328 \ smdk2400 \ smdk2410 \
- suen3 \ trab \ VCMA9 \ versatile \
This is the ARM9 list. Are you sure the board belongs there?
diff --git a/Makefile b/Makefile index 2a06440..3afc4ba 100644 --- a/Makefile +++ b/Makefile @@ -2925,6 +2925,9 @@ smdk2400_config : unconfig smdk2410_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm920t smdk2410 samsung s3c24x0
+suen3_config: unconfig
- @$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) keymile kirkwood
This is the ARM9xxx section. Are you sure the board belongs there?
...
diff --git a/board/keymile/suen3/suen3.c b/board/keymile/suen3/suen3.c new file mode 100644 index 0000000..231745f --- /dev/null +++ b/board/keymile/suen3/suen3.c @@ -0,0 +1,127 @@
...
+int dram_init(void) +{
- int i;
- for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
gd->bd->bi_dram[i].start = kw_sdram_bar(i);gd->bd->bi_dram[i].size = kw_sdram_bs(i);- }
- return 0;
+}
Maybe we can have get_ram_size() support with auto-sizing and testing here?
diff --git a/include/configs/suen3.h b/include/configs/suen3.h new file mode 100644 index 0000000..1b971e0 --- /dev/null +++ b/include/configs/suen3.h
...
+#define CONFIG_EXTRA_ENV_SETTINGS \
- "load=tftp 400000 suen3/u-boot.bin\0" \
- "update=nand erase 0 60000;nand write 400000 0 60000\0" \
- "upd=run load update\0" \
- "mtdparts=orion_nand:512k(uboot),512k@512k(env)," \
"2m@1m(kernel),13m@3m(rootfs)\0" \
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ...
+#define MTDPARTS_DEFAULT "mtdparts=orion_nand:512k(u-boot)," \
"256k(env)," \"2m(kernel)," \"16m(rootfs)," \"32m(fs)," \"-(ubifs)"
This seems inconsistent to me. How about defining MTDPARTS_DEFAULT first, and then just inserting the already defined value, so you can be sure that this doesn;t happen again?
Best regards,
Wolfgang Denk