On 03/11/2016 02:29 PM, Andrew F. Davis wrote:
On 03/11/2016 09:38 AM, Andrew F. Davis wrote:
NFS loading is similar to net loading except initial files are loaded over NFS instead of TFTP, this removes the need for multiple different protocol servers running on the host and allows the use of a single network file system containing boot related files in their usual in-filesystem directory. Add defaults for this boot style here.
Signed-off-by: Andrew F. Davis afd@ti.com
include/configs/ti_armv7_keystone2.h | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/include/configs/ti_armv7_keystone2.h b/include/configs/ti_armv7_keystone2.h index a7206f4..1c6997a 100644 --- a/include/configs/ti_armv7_keystone2.h +++ b/include/configs/ti_armv7_keystone2.h @@ -213,6 +213,7 @@ #define CONFIG_CMD_SF #define CONFIG_CMD_EEPROM #define CONFIG_CMD_USB +#define CONFIG_CMD_NFS
This should not be here. In file included from include/configs/k2g_evm.h:36:0, from include/config.h:5, from include/common.h:18, from include/ubi_uboot.h:17, from drivers/mtd/ubi/attach.c:85: include/configs/ti_armv7_keystone2.h:216:0: warning: "CONFIG_CMD_NFS" redefined #define CONFIG_CMD_NFS
Instead, it should be defined in the k2*_evm_defconfig files if the default was 'n'... but.. cmd/Kconfig defines CMD_NFS as y.
So, all we have to do is drop the CONFIG_CMD_NFS from the header.
We can already see that when folks wanted to disable NFS $ git grep CMD_NFS configs/|grep "is not set" enable: $ git grep CMD_NFS configs/|grep -v "is not set"
it might actually be nicer.. for the actual env variables to eventually get into include/config_distro_bootcmd.h perhaps? I dont know about that atm..