Am 2021-06-29 19:08, schrieb Vladimir Oltean:
From: Vladimir Oltean vladimir.oltean@nxp.com
This series makes the Felix DSA driver initialize all its connected PHYs regardless of whether those will be used for networking or not. This is in order to satisfy the expectations of some software in later boot stages.
To make this work, it is necessary to introduce a new method in struct dsa_ops: .port_probe().
There is some further refactoring/cleanup along the way.
Tested-by: Michael Walle michael@walle.cc
Seems like our PHYs are already in in-band signalling mode. I can't see any difference after applying this series. Neither by using the port in uboot, ie. "bootp; boot" nor booting directly into linux without using the network.
Also, we have two different variants: - one where the switch is used in u-boot and in linux: arch/arm/dts/fsl-ls1028a-kontron-sl28-var2.dtb (DSA support still pending in u-boot) - one where we only use the switch in linux and u-boot doesn't touch the device at all: arch/arm/dts/fsl-ls1028a-kontron-sl28-var4.dtb
Do I understand it correctly, that for the latter variant DPDK would be broken if the PHY hasn't in-band signalling enabled by default? Because u-boot doesn't know the device and it won't setup the PHY correctly.
Oh and I noticed that for var2 "managed = in-band-status" is missing in the linux dtb; what a mess ;) I wonder how this ever worked..
-michael