Hi Jagan,
On 5/27/24 8:39 AM, Jagan Teki wrote:
Add support for USB OTG with UMS to program eMMC.
Add it for Edgeble NCM6A, NCM6B.
Signed-off-by: Jagan Teki jagan@edgeble.ai
.../dts/rk3588-edgeble-neu6a-io-u-boot.dtsi | 18 ++++++++++++++++++ .../dts/rk3588-edgeble-neu6b-io-u-boot.dtsi | 18 ++++++++++++++++++ configs/neu6a-io-rk3588_defconfig | 9 +++++++++ configs/neu6b-io-rk3588_defconfig | 9 +++++++++ 4 files changed, 54 insertions(+)
diff --git a/arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi b/arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi index 88f3f7eee2..534d9f8a2c 100644 --- a/arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi +++ b/arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi @@ -15,3 +15,21 @@ bus-width = <4>; status = "okay"; };
+&u2phy0 {
- status = "okay";
+};
+&u2phy0_otg {
- status = "okay";
+};
+&usbdp_phy0 {
- status = "okay";
+};
+&usb_host0_xhci {
- dr_mode = "peripheral";
- maximum-speed = "high-speed";
- status = "okay";
+}; diff --git a/arch/arm/dts/rk3588-edgeble-neu6b-io-u-boot.dtsi b/arch/arm/dts/rk3588-edgeble-neu6b-io-u-boot.dtsi index 289578803e..b3d17a60ce 100644 --- a/arch/arm/dts/rk3588-edgeble-neu6b-io-u-boot.dtsi +++ b/arch/arm/dts/rk3588-edgeble-neu6b-io-u-boot.dtsi @@ -15,3 +15,21 @@ bus-width = <4>; status = "okay"; };
+&u2phy0 {
- status = "okay";
+};
+&u2phy0_otg {
- status = "okay";
+};
+&usbdp_phy0 {
- status = "okay";
+};
+&usb_host0_xhci {
- dr_mode = "peripheral";
- maximum-speed = "high-speed";
- status = "okay";
+};
I don't see those patches in v6.10-rc1. Have you sent those to upstream already? I assume we should cherry-pick patches in dts/upstream instead of piling stuff up in u-boot.dtsis. This should also bring the patches in rk3588(s).dtsi to add the missing bits for USB support we currently have in rk3588*-u-boot.dtsi?
Cheers, Quentin