On 09/28/12 09:40, Igor Grinberg wrote:
On 09/25/12 22:12, Anatolij Gustschin wrote:
On Fri, 21 Sep 2012 16:21:22 -0700 Tom Rini trini@ti.com wrote: ...
lcd.c: In function 'configuration_get_cmap': lcd.c:513:29: error: 'struct vidinfo' has no member named 'cmap' lcd.c: In function 'lcd_display_bitmap': lcd.c:787:6: warning: implicit declaration of function 'FB_PUT_BYTE' [-Wimplicit-function-declaration] lcd.c: In function 'configuration_get_cmap': lcd.c:515:1: warning: control reaches end of non-void function [-Wreturn-type] make[1]: *** [/home/trini/work/ssd/u-boot/u-boot/trats/common/lcd.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [/home/trini/work/ssd/u-boot/u-boot/trats/common/libcommon.o] Error 2 make: *** Waiting for unfinished jobs....
--------------------- SUMMARY ---------------------------- Boards compiled: 1 Boards with errors: 1 ( trats )
Rejected, please fix and re-submit. Thanks!
Sorry, I trusted the statement of the submitter that he did run MAKEALL for arm and powerpc for these lcd patches, and thus didn't verify by my own MAKEALL tests. I'll fix and resubmit.
You can still trust the submitter, Nikita ran the MAKEALL for arm and ppc. The problem is that it was back in the beginning of August... It is just the time frame between the submission and the pickup that changed things and probably made a difference.
Nikita, has not been around for a while and therefore had no chance to look into your fix and ack it.
Oh, he actually did ack it - I'v missed this, sorry.
Nevertheless, thanks for your patch, that fixed the failing boards.