Hi Mike,
On Tue, Sep 20, 2011 at 6:57 AM, Mike Frysinger vapier@gentoo.org wrote:
On Sunday, September 18, 2011 09:08:35 Graeme Russ wrote:
I mean, it irks me to no end that /common/serial.c, /drivers/serial.c and /include/serial.h are such an ugly mess of #ifdef's - I'm working on a new SoC at the moment, and it just plain weird that I have to touch these :(
well, there's two things there. the init mess which could get fixed in two diff ways: part of your larger init cleanup, or turn it into board callbacks like most of the other frameworks we have atm.
I don't think the serial mess is related to the init sequence at all (but I could be wrong)
the second thing is the CONFIG_SERIAL_MULTI hell. that mess i'd like to gut with a dull blade at some point.
Or a sledgehammer!
The big question I suppose is where we are at with the _MULTI interfaces.
From what I can gather, these should now be the only ones in use and we
should start to apply pressure on board maintainers (i.e. break their boards) to fix any depricated usage. I think the same philosophy should be applied to the various boards with 'flash.c' which should all be using CFI by now.
I've got way to much on my plate to deal with it right now, otherwise I would give it a crack myself - Everyone should know by know that I'm not affraid to stir the pot with some pretty radical code changes ;)
Regards,
Graeme