Re: [U-Boot] [PATCH v5] Add support for Eukrea CPUAT91 SBC

Dear Eric Benard,

In message 1249816414-18989-1-git-send-email-eric@eukrea.com you wrote:

CPUAT91 is built around Atmel's AT91RM9200 and has up to 16MB of NOR flash, up to 128MB of SDRAM, and includes a Micrel KS8721 PHY in RMII mode.

...

+cpuat91_ram_config \ +cpuat91_config : unconfig

• @mkdir -p $(obj)include
• @if [ "$(findstring _ram_,$@)" ] ; then \

• echo "#define CONFIG_SKIP_LOWLEVEL_INIT" >> $(obj)include/config.h; \
  

• echo "#define CONFIG_SKIP_RELOCATE_UBOOT" >> $(obj)include/config.h; \
  

• $(XECHO) "... CPUAT91 configured for RAM" ; \
  

• else \

• echo "#define CONFIG_BOOTDELAY 1" >>$(obj)include/config.h ; \
  

• $(XECHO) "... CPUAT91 configured for Flash" ;\
  

• fi;
• @$(MKCONFIG) -a cpuat91 arm arm920t cpuat91 eukrea at91rm9200

csb637_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm920t csb637 NULL at91rm9200

Please do not add such scripting to the top level Makefile. Perform it in your board config file instead.

For an example, please see http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/65499

+unsigned char ks8721_autonegotiate(AT91PS_EMAC p_mac, int *status) +{

...

• /* Set the Auto_negotiation Advertisement Register */
• /* MII advertising for Next page, 100BaseTxFD and HD, */
• /* 10BaseTFD and HD, IEEE 802.3 */

Incorrect multiline comment style.

Best regards,

Wolfgang Denk