Scott McNutt wrote:
Michal Simek wrote:
Scott McNutt wrote:
CONFIG_SYS_HZ was being calculated (incorrectly) in nios2 configuration headers. Updated comments to accurately describe timebase macros.
Signed-off-by: Scott McNutt smcnutt@psyent.com
include/configs/EP1C20.h | 14 ++++++++------ include/configs/EP1S10.h | 14 ++++++++------ include/configs/EP1S40.h | 14 ++++++++------ include/configs/PCI5441.h | 14 ++++++++------ include/configs/PK1C20.h | 14 ++++++++------ 5 files changed, 40 insertions(+), 30 deletions(-)
This is the next "nice" patch around altera boards.
Agreed.
If you do the same changes (because of the same reason) in 5 files it points me that something is wrong.
IMO, it is inefficient, not wrong. But only because each of these boards worked fine ... until some things changed externally ... that required a common resolution.
I don't have anything against the purpose that patch because fix the real issue. I have just problem with that style of doing it.
I am really not sure what you mean by "until some things changed externally"!
Please create one generic nios2 file and move there these common macros. Look at ppc405/440 which use that style.
It would indeed be more efficient -- perhaps a common header for the Altera boards when time permits.
:-) It is not just to be more efficient. 1. Save u-boot size 2. If is only one place where it is defined than you don't need to spend time to fix all boards which are very similar. It is more bug-free solution.
Regards, Michal
Regards, --Scott