Dear kevin.morfitt
2009/10/6 kevin.morfitt@fearnside-systems.co.uk kevin.morfitt@fearnside-systems.co.uk:
Abdoulaye Walsimou Gaye wrote:
kevin.morfitt@fearnside-systems.co.uk a écrit :
Here are links to the patches and notes on their states:
- [U-boot] [PATCH-ARM] CONFIG_SYS_HZ change for cpu/arm920t/s3c24x0 boards:
http://lists.denx.de/pipermail/u-boot/2009-September/thread.html, JP said it looked OK but needed testing, then it was tested by Wolfgang
- [U-Boot] [PATCH-ARM 1/4, v2] Clean-up of cpu/arm920t and
cpu/arm920t/s3c24x0 code (this patch): one comment so far (your own)
- [U-Boot] [PATCH-ARM 2/4] Clean-up of s3c24x0 header files:
http://lists.denx.de/pipermail/u-boot/2009-September/060111.html, no comments as yet
- [U-Boot] [PATCH-ARM 3/4, v2] Clean-up of s3c24x0 drivers excluding nand
driver, http://lists.denx.de/pipermail/u-boot/2009-September/061583.html, one comment by Gaye Abdoulaye Walsimou, fixed in v2
- [U-Boot] [PATCH-ARM 4/4, v2] Clean-up of s3c24x0 nand driver,
http://lists.denx.de/pipermail/u-boot/2009-September/061584.html, v1 was Acked by Scott here - http://lists.denx.de/pipermail/u-boot/2009-September/060580.html
But there are remained more works for cleaning
My aim is to clean up just the s3c24x0 common code so I can later add support for the Embest SBC2440-II Board. I can see that the rest of the arm920t code also needs cleaning but this would be a much bigger job and could be done later - I'd rather limit these patches to s3c24x0 code.
please use lower case name at C structure's members and functions
I think I have changed all structure names to lower case in the s3c24x0 code. I also think I've changed all function names to lower case except where the change would affect too many other areas - for example, if I change get_HCLK() to get_hclk() in cpu/arm920t/s3c24x0/speed.c I'd also need to change the same in include/common.h, cpu/lh7a40x, arm920t/imx and arm1176/s3c64xx and all functions that call get_HCLK() throughout u-boot. Again, this does need doing but could be done later.
Kevin, As nobody seems to have an objection about your changes, I think you can just go ahead and make available changes to support s3c2440 and your board.
I've missed the merge window for this u-boot release so I may as well submit the s3c2440 and sbc2440-ii board patches after this release.
So far only 1 of the 5 existing patches has been Ack-ed and 1 tested so I need to get them all accepted by the Samsung ARM custodian for this release.
Cheers,
You said "run checkpatch.pl and fix any error reports". but there are still remained error. And please move down to the change log under the "---". change log is not commit message. This comments are equally to the your other patches.
Thanks Minkyu Kang