-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Aggrwal Poonam-B10812 Sent: Wednesday, July 22, 2009 3:45 PM To: Wolfgang Denk; Gala Kumar-B11780 Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH 1/2] Removed CONFIG_NUM_CPUS for 85xx and86xxFreescale processors.
...
+#ifndef CONFIG_MP
- if (cpu_numcores() > 1)
puts("#############################################\n""The system is detected to be MULTICORE,\n""but u-boot is built with UNI-CORE\n""To enable mutlticore Build set CONFIG_MP\n""#############################################\n\n");
#endif
Please use terse error messages. We don't print prose here.
- cpu = identify_cpu(ver);
- if (cpu) {
- if (cpu_numcores() > 1) {
volatile ccsr_pic_t *pic = (void*)(CONFIG_SYS_MPC85xx_PIC_ADDR);
printf("CPU%d: ", pic->whoami);- }
- else
Incorrect brace style.
--- a/cpu/mpc85xx/speed.c +++ b/cpu/mpc85xx/speed.c
...
@@ -51,7 +51,7 @@ void get_sys_info (sys_info_t * sysInfo) /* Divide before multiply to avoid integer * overflow for processor speeds above 2GHz */ half_freqSystemBus = sysInfo->freqSystemBus/2;
- for (i = 0; i < CONFIG_NUM_CPUS; i++) {
- for (i = 0; i < cpu_numcores(); i++) {
Only one space before the '<', please.
...
--- a/cpu/mpc86xx/cpu.c +++ b/cpu/mpc86xx/cpu.c
...
+int probecpu (void) +{
- uint svr;
- uint ver;
- svr = get_svr();
- ver = SVR_SOC_VER(svr);
- gd->cpu = identify_cpu(ver);
- return 0;
+}
+int cpu_numcores() {
- struct cpu_type *cpu;
- cpu = gd->cpu;
- return cpu->num_cores;
+}
This seems to be identically repeated code. Please factor out into common code.
Actually the files cpu/mpc86xx/cpu.c cpu/mpc85xx/cpu.c are quite identical. Kumar, Please suggest how should this be taken care. Probably a single file to take care of 85xx and 86xx don't know?
Just a request , I would like to close this as we need to push P2020RDB support quickly. Otherwise should I just go ahead with 85xx for now? Please suggest. Regards Poonam
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk &
Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194
Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de You can only live once, but if you do it right, once is enough. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot