On 25/04/19 11:57, Joris Offouga wrote:
Le 25/04/2019 à 11:26, Stefano Babic a écrit :
On 25/04/19 11:18, Joris OFFOUGA wrote:
Le jeu. 25 avr. 2019 à 11:12, Stefano Babic <sbabic@denx.de mailto:sbabic@denx.de> a écrit :
On 25/04/19 11:00, Stefano Babic wrote: > On 04/04/19 14:00, Joris Offouga wrote: >> This patch adds DT file hooks for Pico i.MX7D SOM and variant boards >> >> Signed-off-by: Joris Offouga <offougajoris@gmail.com mailto:offougajoris@gmail.com> >> --- >> configs/pico-hobbit-imx7d_defconfig | 3 ++- >> configs/pico-imx7d_defconfig | 3 ++- >> configs/pico-pi-imx7d_defconfig | 3 ++- >> 3 files changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/configs/pico-hobbit-imx7d_defconfig b/configs/pico-hobbit-imx7d_defconfig >> index f58d517..75eab28 100644 >> --- a/configs/pico-hobbit-imx7d_defconfig >> +++ b/configs/pico-hobbit-imx7d_defconfig >> @@ -16,6 +16,8 @@ CONFIG_NR_DRAM_BANKS=1 >> CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg" >> CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run distro_bootcmd" >> CONFIG_DEFAULT_FDT_FILE="imx7d-pico-hobbit.dtb" >> +CONFIG_OF_CONTROL=y >> +CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-hoobit" > ^--- two much "o" > > I fix this myself by merging. > >
However, this fix pico-hobbit-imx7d, but not pico-imx7d. In fact, there is no pico-imx7d.dts, but CONFIG_DEFAULT_DEVICE_TREE is set. Am I missing something ?
No it's just som he does not need to CONFIG_DEFAULT_DEVICE_TREE Best regards,
I suppose this, but then something in the build is broken, If I run buildman, a pico-imx7d board is searched. In fact, there is a configs/pico-imx7d_defconfig. If this is just SOM, this file has no reason to exist.
For pico_imx7d_defconfig, i set CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-pi.dtb"
This is not what I see in your patch http://patchwork.ozlabs.org/patch/1077223/:
+CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico"
I fix myself in the defconfig.
You have to ask Fabio and Otavio I did not grow on it when I did the dm conversion, they asked me to convert everything even som
Just SOM it is quite weird if there is not an evaluation board to support it. Anyway, I fix the name, thanks.
Best regards, Stefano Babic