Hi,
On 07/07/17 04:58, Simon Glass wrote:
Hi Andre,
On 2 July 2017 at 18:59, Andre Przywara andre.przywara@arm.com wrote:
Currently we add the U-Boot specific Ethernet MAC DT nodes for the Pine64 via a board-specific add-on .dtsi. However these nodes and properties in there are actually pretty generic for all A64 boards which use a PHY connected via RGMII. Rename the add-on .dtsi to reflect this and make the Pine64 .dtsi a symlink to this new file. This simplifies letting other boards use the EMAC too.
Signed-off-by: Andre Przywara andre.przywara@arm.com
arch/arm/dts/sun50i-a64-pine64-plus-u-boot.dtsi | 51 +------------------------ arch/arm/dts/sun50i-a64-rgmii-emac.dtsi | 50 ++++++++++++++++++++++++ 2 files changed, 51 insertions(+), 50 deletions(-) mode change 100644 => 120000 arch/arm/dts/sun50i-a64-pine64-plus-u-boot.dtsi create mode 100644 arch/arm/dts/sun50i-a64-rgmii-emac.dtsi
It seems odd to use the U-Boot dtsi feature to add code that should be in the kernel .dts also. Can we instead just #include it?
This -u-boot.dtsi was just a preliminary kludge until the official Linux Ethernet support was merged. I was hoping for getting this still into the release, since it's an easy change and enables TFTP boot on the two boards (this patch here is just preparation for the actual patch 2/6).
So the Linux Ethernet driver happened to be merged yesterday. \O/ I promise to update U-Boot's DTs with the kernel one's once we have at least an -rc1 in the kernel (though this requires patch 6/6 in U-Boot). This will then see these rgmii-emac.dtsi and the symlinks go away.
Cheers, Andre.