On Wed, 11 Dec 2024 at 15:54, Simon Glass sjg@chromium.org wrote:
Update efi_allocate_pool_ext() to log the pointer returned from this call, which can be helpful when debugging.
Can you explain how logging the success is helping? I think its pretty pointless, why not log a failure?
Signed-off-by: Simon Glass sjg@chromium.org
(no changes since v3)
Changes in v3:
- Show the returned address rather than the pointer
Changes in v2:
- Use EFI_PRINT() instead of log_debug()
lib/efi_loader/efi_boottime.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c index 080e7f78ae3..f27b3827ed2 100644 --- a/lib/efi_loader/efi_boottime.c +++ b/lib/efi_loader/efi_boottime.c @@ -13,6 +13,7 @@ #include <irq_func.h> #include <log.h> #include <malloc.h> +#include <mapmem.h> #include <pe.h> #include <time.h> #include <u-boot/crc.h> @@ -511,6 +512,9 @@ static efi_status_t EFIAPI efi_allocate_pool_ext(int pool_type,
EFI_ENTRY("%d, %zu, %p", pool_type, size, buffer); r = efi_allocate_pool(pool_type, size, buffer);
if (r == EFI_SUCCESS)EFI_PRINT("*buffer = %llx\n", (u64)map_to_sysmem(*buffer));
buffer can be null if size == 0
return EFI_EXIT(r);}
-- 2.34.1