Re: [U-Boot] [PATCH v2] gpio: at91_gpio: Add bank names

On 20.11.2019 09:21, Eugen Hristev wrote:

On 19.11.2019 17:56, James Byrne wrote:

...

Make the at91_gpio driver set sensible GPIO bank names in the platform data. This makes the 'gpio status' command a lot more useful.

Signed-off-by: James Byrne james.byrne@origamienergy.com

---

Reviewed-by: Eugen Hristev eugen.hristev@microchip.com

Hi James,

Unfortunately this patch breaks a number of platforms:

smartweb

+drivers/gpio/at91_gpio.c:22:20: error: 'at91_get_bank_name' defined but not used [-Werror=unused-function]

at91rm9200ek at91rm9200ek_ram wb45n picosam9g45 corvus smartweb

+drivers/gpio/at91_gpio.c:22:20: error: 'at91_get_bank_name' defined but not used [-Werror=unused-function]

Can you please fix this ? Otherwise I cannot take this patch.

Thanks ! Eugen