Hi Wolfgang,
On Tue, Nov 1, 2011 at 6:18 PM, Simon Glass sjg@chromium.org wrote:
Hi Wolfgang,
On Tue, Nov 1, 2011 at 2:21 PM, Wolfgang Denk wd@denx.de wrote:
Dear Simon Glass,
In message CAPnjgZ2wW3tvGjxWgkVr0PHLr2Ttj8abtPc4aiyk=tgnpsSk3g@mail.gmail.com you wrote:
I have suggested making these functions available by default, and having CONFIG_NO_SYS_VSNPRINT to remove them. The rationale is that it
This makes little sense to me. We don't need an opt out here, but an opt in instead. Otherwise you willprobably see a number of builds breaking due to the increased code size.
OK I can change this to CONFIG_SYS_VSNPRINT easily enough.
I have done this and sent a new patch series (v6). It does not break any boards so far as I can tell. The code size increase on ARM is about 4 bytes and on PPC is 32 bytes. We can reduce this to closer to zero but it involves #ifdef hassle - please see the patch here:
http://patchwork.ozlabs.org/patch/120352/
Regards, Simon