On Monday, December 20, 2010 05:49:22 Wolfgang Denk wrote:
Mike Frysinger wrote:
no, that doesnt make any sense. just because i want some of the boards i maintain to favor speed over size doesnt mean every board maintainer should. thus the settings are in the board-specific config.mk where they should be.
We have here: CONFIG_BFIN_CPU = bf525-0.2 LDR_FLAGS += $(LDR_FLAGS-$(CONFIG_BFIN_BOOT_MODE))
Which these fall into that group?
i dont understand the question, so i'll just spout random noise.
Well, your argument was the need to provide board or file specific optimizer options to "favor speed over size ...". To me it seems this argument has nothing to do with what the definitions above are doing.
i was responding to your *general* statement that you wish to get rid of all board config.mk's. and my simple response that this goal is not feasible. so to back up my statement with fact, i gave real world examples that are not attainable if you punt all board config.mk's.
the LDR_FLAGS-y convention is board specific and is only set in boards' config.mk. i could unify that convention across all Blackfin boards and move this one specific line to the common Blackfin config.mk, but that still
OK, then please let's do this. I guess this will allow to remove a number of other config.mk files as well.
np
as for the cpu selection, obviously that cannot be in any common file since the cpu variant and silicon rev is about as board specific as you could possibly get.
And why cannot it be set in the board config file like every other board doing it?
ive explained in the past why. one of the reasons why i think config.mk makes more sense is this setting is only used for compilation (build flags). it isnt used directly anywhere in the config.h or related code. i also find it significantly cleaner than the cpu handling as found in the arm or m68k or ppc ports where copy & pasting swaths of code is the rule. -mike