Re: [U-Boot] [PATCH 02/16] arch/arm/lib/bootm.c: Optionally use existing atags

On Sunday 18 December 2011 13:54:21 Mike Frysinger wrote:

On Saturday 17 December 2011 12:03:04 Pali Rohár wrote:

...

• s = getenv ("atagaddr");

no space before the "("

...

#if defined (CONFIG_SETUP_MEMORY_TAGS) || \

 defined (CONFIG_CMDLINE_TAG) || \
 defined (CONFIG_INITRD_TAG) || \
 defined (CONFIG_SERIAL_TAG) || \
 defined (CONFIG_REVISION_TAG)

... +#if defined (CONFIG_SETUP_MEMORY_TAGS) || \

• defined (CONFIG_CMDLINE_TAG) || \
• defined (CONFIG_INITRD_TAG) || \
• defined (CONFIG_SERIAL_TAG) || \
• defined (CONFIG_REVISION_TAG)

rather than duplicating the same list in multiple places, why not setup a local define in this file and then use that everywhere else. -mike

I will add local define CONFIG_ANY_TAG to bootm.c

+#if defined (CONFIG_SETUP_MEMORY_TAGS) || \ + defined (CONFIG_CMDLINE_TAG) || \ + defined (CONFIG_INITRD_TAG) || \ + defined (CONFIG_SERIAL_TAG) || \ + defined (CONFIG_REVISION_TAG) +#define CONFIG_ANY_TAG +#endif