7 Jul
2014
7 Jul
'14
6:47 p.m.
On Mon, Jul 07, 2014 at 04:10:42PM +0100, Ian Campbell wrote:
On Mon, 2014-07-07 at 14:50 +0200, Hans de Goede wrote:
AFAIK we will never define both EMAC and GMAC for the same board,
If we are sure of this (and I suspect this is the case, since IIRC they share some pins) then I agree with your suggestion.
so IMHO a better fix would be to change this line:
rc = sunxi_emac_initialize(bis);
to:
int rc = sunxi_emac_initialize(bis);
That's not how we like things to look however when we can help it. Just toss a __maybe_unused in front of the declaration (and make sure we have <linux/compiler.h> included.
--
Tom