Re: [U-Boot] [PATCH v2 3/3] imx:mx6slevk implement power init board

Hi, Fabio

On 2/11/2015 10:13 PM, Fabio Estevam wrote:

On Wed, Feb 11, 2015 at 12:09 PM, Peng Fan Peng.Fan@freescale.com wrote:

...

+int power_init_board(void) +{

•   struct pmic *p;
  

•   unsigned int ret;
  

•   p = pfuze_common_init(I2C_PMIC);
  

•   if (!p)
  

•           return -ENODEV;
  

•   ret = pfuze_mode_init(p, APS_PFM);
  

•   if (ret < 0)
  

•           return ret;
  

•   return 0;
  

What about doing 'return pfuze_mode_init(p, APS_PFM);' instead?

Then you can get rid of the 'ret' variable and save some lines of code.

This is a good suggestion. I have fixed this and sent out a new v3 version.

Thanks

Thanks Peng.