RE: [EXT] Re: [PATCH] rtc: pcf2127: fix uninitialized variable msg

On 09/07/2020 12.58, Biwen Li wrote:

...

From: Biwen Li biwen.li@nxp.com

Fix uninitialized variable msg

  struct dm_i2c_chip *chip = dev_get_parent_platdata(dev);

• struct i2c_msg msg;
  

• struct i2c_msg msg = {0};
  int ret;
  
  /* Set the address of the start register to be read */
  
  

I assume it's the

    msg.flags |= I2C_M_RD;

line that is warned about (please include such info)? Isn't the right fix to replace that by

    msg.flags = I2C_M_RD;

?

Two lines("struct i2c msg;" and "msg.flags |= I2C_M_RD") are warned by build system. Initializing msg variable will be better.

Rasmus