Fabio Estevam wrote:
Hi Stefano,
Hi Fabio,
udelay(200); mxc_gpio_set(46);
This must be,
What do you think ?
Yes, I agree. Do you plan to send a patch for mx51evk using this approach?
If you do, then I can re-submit my patch after your update.
I sent today a patch adding a common way to access gpios for i.MX31 and i.MX51:
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/83163
I have another issue. It seems to me that the lines you want to add are already in the code, only some lines later:
263 /* Enable VGEN3, VCAM, VAUDIO, VVIDEO, VSD regulators */ 264 val = VGEN3EN | VGEN3CONFIG | VCAMEN | VCAMCONFIG | 265 VVIDEOEN | VAUDIOEN | VSDEN; 266 pmic_reg_write(REG_MODE_1, val); 267 268 udelay(500); 269 270 reg = readl(GPIO2_BASE_ADDR + 0x0); 271 reg |= 0x4000; 272 writel(reg, GPIO2_BASE_ADDR + 0x0);
This is exactly what you want to add, only after setting the regulators. Why do we need to set the gpio twice ?
Best regards, Stefano Babic